Add analyzers for Regex.Match(...).Success and Regex.Matches(...).Count #7547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
force-pushed
the
addregexismatchcountanalyzer
branch
from
06fd4bf to
fd62b29
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7547 +/- ##
==========================================
- Coverage 96.50% 96.50% -0.01%
==========================================
Files 1452 1455 +3
Lines 347575 347963 +388
Branches 11418 11427 +9
==========================================
+ Hits 335436 335798 +362
- Misses 9244 9265 +21
- Partials 2895 2900 +5 |
joperezr
reviewed
Jan 30, 2025
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/UseRegexMembers.cs
Show resolved
Hide resolved
joperezr
reviewed
Jan 30, 2025
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/UseRegexMembers.cs
Show resolved
Hide resolved
stephentoub
force-pushed
the
addregexismatchcountanalyzer
branch
from
fd62b29 to
74d5759
Compare
|
@joperezr, could you re-approve? I rebased to renumber the analyzers after another new one was merged with a conflicting number. Thanks. |
joperezr
approved these changes
Jan 31, 2025
|
Not sure if my approval works though, looks like I don't have write access to the repo |
|
Ah, you're right, thanks, anyway. |
|
@jeffhandley, can you review or find someone to? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/runtime#111238
Fixes dotnet/runtime#111240